Skip to content

Use smart_open package#63

Merged
sethaxen merged 10 commits intomasterfrom
smart_open
Jun 4, 2022
Merged

Use smart_open package#63
sethaxen merged 10 commits intomasterfrom
smart_open

Conversation

@sethaxen
Copy link
Copy Markdown
Collaborator

@sethaxen sethaxen commented Jun 2, 2022

This PR moves away from using the (hackish) smart_open function in python_utilities to the well-tested smart_open.open function in the smart_open package.

Fixes #57 and #47

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 2, 2022

Codecov Report

Merging #63 (88085e4) into master (442f511) will increase coverage by 0.01%.
The diff coverage is 62.50%.

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
+ Coverage   57.18%   57.20%   +0.01%     
==========================================
  Files          18       18              
  Lines        2747     2748       +1     
  Branches      539      539              
==========================================
+ Hits         1571     1572       +1     
  Misses       1060     1060              
  Partials      116      116              
Impacted Files Coverage Δ
e3fp/fingerprint/fprint.py 54.78% <33.33%> (ø)
e3fp/fingerprint/structs.py 71.42% <50.00%> (ø)
e3fp/conformer/util.py 43.69% <57.14%> (+0.23%) ⬆️
e3fp/fingerprint/db.py 76.53% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 442f511...88085e4. Read the comment docs.

@sethaxen sethaxen merged commit 2545498 into master Jun 4, 2022
@sethaxen sethaxen deleted the smart_open branch June 4, 2022 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Error retrieving mol from sdf"

2 participants