Fix for --incompatible_no_implicit_file_export#122
Merged
keith merged 1 commit intokeith:mainfrom Aug 29, 2025
Merged
Conversation
|
@keith ping |
Currently the toolchain references the downloaded buildifier/buildozer by the downloaded filename and ignores the `filegroup()` generated by `http_file()`. This breaks bazel visibility checking if we try to run `bazel test //.. --incompatible_no_implicit_file_export`. We are already specifying a `downleaded_file_path` to `http_file()`, so referecing the generade `:file` target will work on all platforms.
keith
force-pushed
the
fix-incompatible_no_implicit_file_export
branch
from
b42d9e6 to
4253acf
Compare
keith
approved these changes
Aug 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the toolchain references the downloaded buildifier/buildozer by the downloaded filename and ignores the
filegroup()generated byhttp_file(). This breaks bazel visibility checking if we try to runbazel test //.. --incompatible_no_implicit_file_export.We are already specifying a
downleaded_file_pathtohttp_file(), so referencing the generated:filetarget will work on all platforms.