Skip to content

Comments

Feat/finalize ci and docs#2

Merged
kek-Sec merged 5 commits intomainfrom
feat/finalize-ci-and-docs
Dec 30, 2024
Merged

Feat/finalize ci and docs#2
kek-Sec merged 5 commits intomainfrom
feat/finalize-ci-and-docs

Conversation

@kek-Sec
Copy link
Owner

@kek-Sec kek-Sec commented Dec 30, 2024

This pull request includes several significant changes to streamline the build process, improve the Dockerfile, and clean up the Makefile. The most important changes include switching to make commands in the GitHub Actions workflow, adding versioning to the Dockerfile, and refining the Makefile with additional comments and removal of unnecessary targets.

Improvements to build process:

  • .github/workflows/build-test.yml: Replaced direct go commands with make commands for building and testing the Go project. This change ensures consistency by using the Makefile for these operations. [1] [2]

Dockerfile enhancements:

  • Dockerfile: Added VERSION argument and environment variable to the Dockerfile, which is used in the build command to embed the version into the binary. [1] [2]

Makefile refinements:

  • Makefile: Changed variable assignments to use := for consistency, added comments for each target, and removed unnecessary targets such as install-deps, migrate, seed, and cleanup. This cleanup simplifies the Makefile and focuses on the essential build and run tasks.

Script removals:

  • scripts/cleanup.sh: Removed the cleanup script that was used to remove expired URLs from the database.
  • scripts/seed.sh: Removed the seed script that was used to populate the database with test data.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@kek-Sec kek-Sec merged commit 5eb19f2 into main Dec 30, 2024
7 checks passed
@kek-Sec kek-Sec deleted the feat/finalize-ci-and-docs branch December 30, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant