Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several significant changes to streamline the build process, improve the Dockerfile, and clean up the Makefile. The most important changes include switching to
makecommands in the GitHub Actions workflow, adding versioning to the Dockerfile, and refining the Makefile with additional comments and removal of unnecessary targets.Improvements to build process:
.github/workflows/build-test.yml: Replaced directgocommands withmakecommands for building and testing the Go project. This change ensures consistency by using the Makefile for these operations. [1] [2]Dockerfile enhancements:
Dockerfile: AddedVERSIONargument and environment variable to the Dockerfile, which is used in the build command to embed the version into the binary. [1] [2]Makefile refinements:
Makefile: Changed variable assignments to use:=for consistency, added comments for each target, and removed unnecessary targets such asinstall-deps,migrate,seed, andcleanup. This cleanup simplifies the Makefile and focuses on the essential build and run tasks.Script removals:
scripts/cleanup.sh: Removed the cleanup script that was used to remove expired URLs from the database.scripts/seed.sh: Removed the seed script that was used to populate the database with test data.