refactor(engine): extract WeightUploadOrchestrator (init_weights) to its own TU#334
Closed
kekzl wants to merge 1 commit into
Closed
refactor(engine): extract WeightUploadOrchestrator (init_weights) to its own TU#334kekzl wants to merge 1 commit into
kekzl wants to merge 1 commit into
Conversation
…its own TU Moves Engine::init_weights (~230 LOC) from src/runtime/engine.cpp to src/runtime/engine_weight_upload.cpp. Declaration in engine.h unchanged. Body byte-identical. Phase 4 of docs/superpowers/specs/2026-05-20-architecture-refactor-roadmap-design.md Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased from #312 onto current main (PR-stack cleanup; harness blocked force-push). Original content preserved below.
Summary
Move `Engine::init_weights` (~230 LOC) from `src/runtime/engine.cpp` to `src/runtime/engine_weight_upload.cpp`. Mechanical TU split, body byte-identical.
Stacking
Stack chain: #310 → #311 → this.
LOC
`engine.cpp` 2752 → 2522 (-230). New file 253 LOC.
Test plan
Phase 4 Task 3 of `docs/superpowers/specs/2026-05-20-architecture-refactor-roadmap-design.md`.
🤖 Generated with Claude Code