Deye/Sunsynk 3-phae inverter sensors for inverter and load added#380
Merged
kellerza merged 3 commits intokellerza:mainfrom Jan 5, 2025
Merged
Deye/Sunsynk 3-phae inverter sensors for inverter and load added#380kellerza merged 3 commits intokellerza:mainfrom
kellerza merged 3 commits intokellerza:mainfrom
Conversation
Contributor
According to modbus docs, the above need to be signed like so: |
Contributor
Author
|
Actually I used this doc: https://forum.iobroker.net/assets/uploads/files/1712644425833-c3ca14a0-178c-4f68-be8c-fa68a414b97b-deye-sun-inverter-modbus-en.pdf |
Contributor
In the third column you can see it says S16 - signed 16 bits. For signed registers, the code handles them as such when factor is below 0. |
Contributor
Author
|
That makes 100% sense for current. I already pushed a new commit. |
Owner
|
Thanks @proggaras! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some sensors for the Deye/Sunsynk 3-phae inverter where corrected and added.
Thx. for reviewing.