Create single_phase_16kw.py by deondti · Pull Request #405 · kellerza/sunsynk

deondti · 2025-01-22T11:56:11Z

Creating a " single_phase_16kw.py" definition.
Major changes from 5/8Kw to 16Kw
Sensor(172, "Grid_Ct_Power_10", WATT, -10),
Sensor(169, "Grid_power_10", WATT, -10),

SENSORS += NumberRWSensor(230, "Grid Charge Battery current", AMPS, min=0, max=140) SENSORS += NumberRWSensor(210, "Battery Max Charge current", AMPS, min=0, max=290) SENSORS += NumberRWSensor(211, "Battery Max Discharge current", AMPS, min=0, max=290)

Battery charge MAX is derived from the physical inverter LCD settings.

Grid and CT power is because it would only read eg. 500W instead of 5000W

Creating a " single_phase_16kw.py" definition. Major changes from 5/8Kw to 16Kw Sensor(172, "Grid_Ct_Power_10", WATT, -10), Sensor(169, "Grid_power_10", WATT, -10), SENSORS += NumberRWSensor(230, "Grid Charge Battery current", AMPS, min=0, max=140) SENSORS += NumberRWSensor(210, "Battery Max Charge current", AMPS, min=0, max=290) SENSORS += NumberRWSensor(211, "Battery Max Discharge current", AMPS, min=0, max=290) Battery charge MAX is derived from the physical inverter LCD settings. Grid and CT power is because it would only read eg. 500W instead of 5000W

codecov · 2025-01-22T12:10:23Z

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 71.16%. Comparing base (81d718c) to head (f87a56d).
Report is 7 commits behind head on main.

Files with missing lines	Patch %	Lines
src/sunsynk/definitions/single_phase_16kw.py	0.00%	9 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #405      +/-   ##
==========================================
- Coverage   71.49%   71.16%   -0.34%     
==========================================
  Files          27       28       +1     
  Lines        1912     1921       +9     
==========================================
  Hits         1367     1367              
- Misses        545      554       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kellerza · 2025-01-22T12:12:35Z

If you import from the single_phase you only need to define changes & not all sensors

look at 3ph lv & hv to see how this is done
Import SENSORS, create a copy and add sensors to overwrote ones with the same name

deondti

corrected?

Co-authored-by: Johann Kellerman <kellerza@gmail.com>

kellerza · 2025-01-23T19:01:28Z

The selection mechanism is still pending. Or do you prefer me to work on that?

deondti · 2025-01-24T06:13:59Z

The selection mechanism is still pending. Or do you prefer me to work on that?

config.yaml added sensor definition, documentation ammended
Where/what else needs to change?
I really don't know much...... learning as I go

kellerza · 2025-01-24T12:20:37Z

Just commit changes to this branch, then it will update

deondti · 2025-01-24T13:10:57Z

Just commit changes to this branch, then it will update

Please help , I think I'm stuck.
To me it looks like the file is in the branch but I don't think it is...
or am I just being a noob ?

kellerza · 2025-01-24T14:09:30Z

The best would be to install pre-commit locally & use that to fix up your tests that are failing.

pip install pre-commit
git add . && pre-commit run --all

I implemented dynamic loading, so you should just add single-phase-16kw to config.yaml in the edge addon folder

you can also rebase on the latest changes (after a commit!) using git pull --rebase, maybe you need to include "upstream main" as part of your rebase

kellerza · 2025-01-27T12:48:26Z

+SENSORS += NumberRWSensor(210, "Battery Max Charge current", AMPS, min=0, max=290)
+SENSORS += NumberRWSensor(211, "Battery Max Discharge current", AMPS, min=0, max=290)
+
+)


You probably need to delete line 40 to make the test pass?

Skip to content
Navigation Menu

kellerza sunsynk

Code
Issues 23
Pull requests 4
Discussions
Actions
Projects
Security

Insights

Back to pull request #405
Create single_phase_16kw.py #286

Jobs

Run details

Annotations
1 error and 1 warning
Check pylint
failed Jan 27, 2025 in 28s
1s
0s
0s
18s
8s
Run pylint src
pylint src
shell: /usr/bin/bash -e {0}
env:
DEFAULT_PYTHON: 3.11
pythonLocation: /opt/hostedtoolcache/Python/3.11.11/x64
PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.11.11/x64/lib/pkgconfig
Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.11.11/x64
Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.11.11/x64
Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.11.11/x64
LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.11.11/x64/lib
************* Module sunsynk.definitions.single_phase_16Kw
src/sunsynk/definitions/single_phase_16Kw.py:32:0: C0303: Trailing whitespace (trailing-whitespace)
src/sunsynk/definitions/single_phase_16Kw.py:40:0: C0305: Trailing newlines (trailing-newlines)
src/sunsynk/definitions/single_phase_16Kw.py:1:0: C0103: Module name "single_phase_16Kw" doesn't conform to snake_case naming style (invalid-name)
src/sunsynk/definitions/single_phase_16Kw.py:3:0: W0611: Unused CELSIUS imported from sunsynk (unused-import)
src/sunsynk/definitions/single_phase_16Kw.py:3:0: W0611: Unused KWH imported from sunsynk (unused-import)
src/sunsynk/definitions/single_phase_16Kw.py:3:0: W0611: Unused VOLT imported from sunsynk (unused-import)
src/sunsynk/definitions/single_phase_16Kw.py:5:0: W0611: Unused SelectRWSensor imported from sunsynk.rwsensors (unused-import)
src/sunsynk/definitions/single_phase_16Kw.py:5:0: W0611: Unused SwitchRWSensor imported from sunsynk.rwsensors (unused-import)
src/sunsynk/definitions/single_phase_16Kw.py:5:0: W0611: Unused SystemTimeRWSensor imported from sunsynk.rwsensors (unused-import)
src/sunsynk/definitions/single_phase_16Kw.py:5:0: W0611: Unused TimeRWSensor imported from sunsynk.rwsensors (unused-import)
src/sunsynk/definitions/single_phase_16Kw.py:12:0: W0611: Unused BinarySensor imported from sunsynk.sensors (unused-import)
src/sunsynk/definitions/single_phase_16Kw.py:12:0: W0611: Unused FaultSensor imported from sunsynk.sensors (unused-import)
src/sunsynk/definitions/single_phase_16Kw.py:12:0: W0611: Unused InverterStateSensor imported from sunsynk.sensors (unused-import)
src/sunsynk/definitions/single_phase_16Kw.py:12:0: W0611: Unused MathSensor imported from sunsynk.sensors (unused-import)
src/sunsynk/definitions/single_phase_16Kw.py:12:0: W0611: Unused SDStatusSensor imported from sunsynk.sensors (unused-import)
src/sunsynk/definitions/single_phase_16Kw.py:12:0: W0611: Unused TempSensor imported from sunsynk.sensors (unused-import)

Your code has been rated at 9.91/10

Error: Process completed with exit code 20.
0s
0s
0s
Create single_phase_16kw.py · 7bd9b81

deondti · 2025-01-28T09:53:05Z

Hi @kellerza

Am I on the right track?

Could you please help with these last 2 errors? I have no idea what it means...

In codecov

kellerza · 2025-01-28T12:04:54Z

      DONGLE_SERIAL_NUMBER: str?
      PORT: str
-  SENSOR_DEFINITIONS: list(single-phase|three-phase|three-phase-hv)
+  SENSOR_DEFINITIONS: list(single-phase|single-phase-16Kw|three-phase|three-phase-hv)


Either all names needs to be lowercase, or we need a .lower() in the load function in definitions/init.py

Kw will not match the filename kw today

I'm only stuck with codecov now, it helps to read, think and solve but codecov is another story...

Codecov should be taken care of by a previous commit. It imports and tests all the existing definition files.

kellerza · 2025-01-28T13:59:54Z

Thanks @deondti !

you should be able to test this once the edge version is built

deondti · 2025-01-28T14:06:44Z

sorry for the lengthy mess and THANK YOU for your patience

deondti · 2025-01-28T17:48:14Z

Tested and seems to be fine, thank you again for this great project

talabirast · 2026-02-01T23:33:44Z

I haven't fully tested it yet, but it seems that this mode also works on deye single_phase_18kw

Update single_phase_16kw.py

1db1870

deondti commented Jan 22, 2025

View reviewed changes

kellerza reviewed Jan 22, 2025

View reviewed changes

Comment thread src/sunsynk/definitions/single_phase_16kw.py Outdated

kellerza mentioned this pull request Jan 22, 2025

Update single_phase.py #399

Closed

Update src/sunsynk/definitions/single_phase_16kw.py

ddfbecb

Co-authored-by: Johann Kellerman <kellerza@gmail.com>

deondti added 2 commits January 24, 2025 14:57

Update single_phase_16kw.py

1746e7e

Update single_phase_16kw.py

0abf6b9

This was referenced Jan 24, 2025

Dynamically load sensor definitions. Pin ruff to 0.9.3 #417

Merged

Update multi-options.md #414

Closed

deondti added 5 commits January 27, 2025 09:19

Merge branch 'kellerza:main' into patch-3

4ea479b

Rename single_phase_16kw.py to single_phase_16Kw.py

f5b2f4e

Update single_phase_16Kw.py

3c35728

Update single_phase_16Kw.py

5d18662

Update config.yaml

bb928bd

kellerza reviewed Jan 27, 2025

View reviewed changes

deondti added 7 commits January 27, 2025 14:48

Update single_phase_16Kw.py

f726e32

Update single_phase_16Kw.py

4fc9bf1

Update single_phase_16Kw.py

7bd9b81

Rename single_phase_16Kw.py to single_phase_16kw.py

622738d

Update single_phase_16kw.py

e0ab4f3

Update single_phase_16kw.py

41ae458

Update single_phase_16kw.py

e612395

deondti added 4 commits January 28, 2025 12:15

Update single_phase_16kw.py

06ae0d5

Update single_phase_16kw.py

6682632

Update single_phase_16kw.py

7473685

Update single_phase_16kw.py

e53cf68

kellerza reviewed Jan 28, 2025

View reviewed changes

Update config.yaml

f87a56d

kellerza merged commit ca73003 into kellerza:main Jan 28, 2025

Conversation

deondti commented Jan 22, 2025

Uh oh!

codecov bot commented Jan 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

kellerza commented Jan 22, 2025

Uh oh!

deondti left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kellerza commented Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

deondti commented Jan 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kellerza commented Jan 24, 2025

Uh oh!

deondti commented Jan 24, 2025

Uh oh!

kellerza commented Jan 24, 2025

Uh oh!

kellerza Jan 27, 2025

Choose a reason for hiding this comment

Uh oh!

deondti Jan 27, 2025

Choose a reason for hiding this comment

Uh oh!

deondti commented Jan 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kellerza Jan 28, 2025

Choose a reason for hiding this comment

Uh oh!

deondti Jan 28, 2025

Choose a reason for hiding this comment

Uh oh!

kellerza Jan 28, 2025

Choose a reason for hiding this comment

Uh oh!

kellerza commented Jan 28, 2025

Uh oh!

deondti commented Jan 28, 2025

Uh oh!

deondti commented Jan 28, 2025

Uh oh!

talabirast commented Feb 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Jan 22, 2025 •

edited

Loading

kellerza commented Jan 23, 2025 •

edited

Loading

deondti commented Jan 24, 2025 •

edited

Loading

deondti commented Jan 28, 2025 •

edited

Loading