Merged
Conversation
- Updated artifact naming to include sanitized platform name and added error handling for missing files. - Changed the download artifact step to use a pattern for better flexibility. - Configured Git settings for the action and implemented a rebase strategy before committing version updates. - Added logic to conditionally update the version for the multi platform based on the environment. - Improved push logic with retry mechanism for better reliability. This update streamlines the deployment process and ensures version consistency across platforms.
- Updated job conditions to improve handling of workflow events, specifically for 'workflow_run' scenarios. - Enhanced failure handling in the CI job by explicitly exiting with an error code. - Adjusted the 'information' job to trigger on additional event types, ensuring better integration with release processes. - Streamlined conditions for the 'publish_addon' job to ensure it only runs when all dependencies succeed. These changes enhance the robustness and reliability of the deployment process.
- Introduced a retry mechanism with exponential backoff for the manifest creation and image inspection steps to improve reliability. - Implemented batch processing for manifest creation to handle digests in smaller groups, reducing the risk of failures during the process. - Added logging for batch processing to provide better visibility into the workflow execution. These changes enhance the robustness of the deployment process, ensuring smoother multi-platform deployments.
- Added logging statements to indicate wait periods during manifest creation and image inspection steps. - Introduced consistent wait times (30 seconds after manifest creation, 10 seconds between platform inspections, and 5 seconds before retrying pushes) to improve stability and reliability of the deployment process. These changes aim to provide better visibility into the workflow execution and ensure smoother multi-platform deployments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rate Limiting and Workflow Improvements
This PR addresses the "429 Too Many Requests" errors encountered during image manifest creation and improves the overall reliability of the deployment workflow.
Key Changes
1. Sequential Manifest Processing
2. Enhanced Retry Mechanism
3. Improved Git Operations
4. Better Visibility
Testing
The changes have been tested with multiple platforms (amd64, arm64, armv7, armv6) and handle rate limiting gracefully.
Impact
Related issues