Build release binary on main merge#2
Conversation
Co-authored-by: kelleyblackmore <kelleyblackmore@gmail.com>
|
Cursor Agent can help with this pull request. Just |
Co-authored-by: kelleyblackmore <kelleyblackmore@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR adds a GitHub Actions workflow to build release binaries for pull requests targeting the main branch, along with code formatting improvements in several Rust source files. The most significant functional change is in the secret rotation logic, which now preserves existing metadata when rotating secrets.
Key Changes
- Added a new GitHub Actions workflow that builds and uploads release binaries on PR events
- Updated
rotate_secretfunction to preserve existing metadata instead of overwriting it - Applied consistent multi-line formatting to various function calls and error messages
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/build-release-binary.yml |
New workflow to build release binaries on PR events targeting main |
src/rotation.rs |
Metadata preservation logic and code formatting improvements |
src/vault.rs |
Multi-line formatting for error message |
src/main.rs |
Multi-line formatting for print and log statements |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| name: Build Release Binary | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: | ||
| - main | ||
| types: | ||
| - opened | ||
| - synchronize | ||
| - reopened | ||
| - ready_for_review |
There was a problem hiding this comment.
The workflow name and PR title say 'Build release binary on main merge', but the workflow triggers on pull request events (opened, synchronize, reopened, ready_for_review), not on merge to main. Consider renaming the workflow to 'Build Release Binary for PRs' or changing the trigger to push: branches: [main] to align with the stated purpose.
There was a problem hiding this comment.
💡 Codex Review
The workflow triggers only on pull_request events of type opened, synchronize, reopened, and ready_for_review. It never fires when a PR is merged, so the merged commit on main does not produce a release binary or artifact despite the stated goal of building a release binary when changes land on main. Consider adding a push trigger for main or including the pull_request closed event with if: github.event.pull_request.merged so the release build happens for the code that actually becomes part of main.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Add a GitHub Action to build a release binary for PRs targeting main.