Skip to content

Build release binary on main merge#2

Merged
kelleyblackmore merged 2 commits into
mainfrom
cursor/build-release-binary-on-main-merge-2617
Nov 12, 2025
Merged

Build release binary on main merge#2
kelleyblackmore merged 2 commits into
mainfrom
cursor/build-release-binary-on-main-merge-2617

Conversation

@kelleyblackmore
Copy link
Copy Markdown
Owner

Add a GitHub Action to build a release binary for PRs targeting main.


Open in Cursor Open in Web

Co-authored-by: kelleyblackmore <kelleyblackmore@gmail.com>
@cursor
Copy link
Copy Markdown

cursor Bot commented Nov 12, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

Co-authored-by: kelleyblackmore <kelleyblackmore@gmail.com>
@kelleyblackmore kelleyblackmore marked this pull request as ready for review November 12, 2025 06:18
Copilot AI review requested due to automatic review settings November 12, 2025 06:18
@kelleyblackmore kelleyblackmore merged commit 131af6a into main Nov 12, 2025
6 checks passed
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a GitHub Actions workflow to build release binaries for pull requests targeting the main branch, along with code formatting improvements in several Rust source files. The most significant functional change is in the secret rotation logic, which now preserves existing metadata when rotating secrets.

Key Changes

  • Added a new GitHub Actions workflow that builds and uploads release binaries on PR events
  • Updated rotate_secret function to preserve existing metadata instead of overwriting it
  • Applied consistent multi-line formatting to various function calls and error messages

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/build-release-binary.yml New workflow to build release binaries on PR events targeting main
src/rotation.rs Metadata preservation logic and code formatting improvements
src/vault.rs Multi-line formatting for error message
src/main.rs Multi-line formatting for print and log statements

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +1 to +11
name: Build Release Binary

on:
pull_request:
branches:
- main
types:
- opened
- synchronize
- reopened
- ready_for_review
Copy link

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow name and PR title say 'Build release binary on main merge', but the workflow triggers on pull request events (opened, synchronize, reopened, ready_for_review), not on merge to main. Consider renaming the workflow to 'Build Release Binary for PRs' or changing the trigger to push: branches: [main] to align with the stated purpose.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

name: Build Release Binary
on:
pull_request:
branches:
- main
types:
- opened
- synchronize
- reopened
- ready_for_review

P1 Badge Run workflow on merge to main

The workflow triggers only on pull_request events of type opened, synchronize, reopened, and ready_for_review. It never fires when a PR is merged, so the merged commit on main does not produce a release binary or artifact despite the stated goal of building a release binary when changes land on main. Consider adding a push trigger for main or including the pull_request closed event with if: github.event.pull_request.merged so the release build happens for the code that actually becomes part of main.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@kelleyblackmore kelleyblackmore deleted the cursor/build-release-binary-on-main-merge-2617 branch November 12, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants