feat(Bandcamp): set creative commons license URL if available#20
Merged
kellnerd merged 1 commit intokellnerd:mainfrom Jun 10, 2024
Merged
feat(Bandcamp): set creative commons license URL if available#20kellnerd merged 1 commit intokellnerd:mainfrom
kellnerd merged 1 commit intokellnerd:mainfrom
Conversation
This also generally completes the support for external links of type "license". Fixes kellnerd#19
Collaborator
Author
|
As a side note I think it might be helpful to actually handle the HTML response with a HTML parser and be able to use CSS path queries on it. Would lead to more robust code than the current regular expression based approach. |
kellnerd
approved these changes
Jun 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extracts Creative Common license URLs from Bandcamp pages and submits them as license URL link to MB.
This also generally completes the support for external links of type "license". Fixes #19
Some examples for testing: