Skip to content

feat(Bandcamp): set creative commons license URL if available#20

Merged
kellnerd merged 1 commit intokellnerd:mainfrom
phw:bandcamp-license
Jun 10, 2024
Merged

feat(Bandcamp): set creative commons license URL if available#20
kellnerd merged 1 commit intokellnerd:mainfrom
phw:bandcamp-license

Conversation

@phw
Copy link
Collaborator

@phw phw commented Jun 8, 2024

This extracts Creative Common license URLs from Bandcamp pages and submits them as license URL link to MB.

This also generally completes the support for external links of type "license". Fixes #19

Some examples for testing:

This also generally completes the support for external links of type
"license". Fixes kellnerd#19
@phw
Copy link
Collaborator Author

phw commented Jun 8, 2024

As a side note I think it might be helpful to actually handle the HTML response with a HTML parser and be able to use CSS path queries on it. Would lead to more robust code than the current regular expression based approach.

@kellnerd kellnerd added feature New feature or request Bandcamp labels Jun 9, 2024
@kellnerd kellnerd merged commit 5829959 into kellnerd:main Jun 10, 2024
@phw phw deleted the bandcamp-license branch June 10, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bandcamp feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support setting CC license for Bandcamp provider

2 participants