Refactor: Smart defaults and template de-duplication#60
Merged
secana merged 1 commit intokellnr:mainfrom Feb 14, 2026
Merged
Conversation
secana
approved these changes
Feb 14, 2026
This was referenced Feb 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed:
nulinvalues.yaml. Now environment variables are onyl generated if a user actually sets them.config.yamlandsecret-config.yaml#59): Moved the variable logic to single shared helper (kellnr.envVars). Both the ConfigMap and Secret now pull from this one source.Testing:
Verified with
helm templatethat variables appear whensetand disappear whennull.Note: There are some blank lines in the rendered output because I avoided using whitespace-stripping tags
({{- ... -}})inside logic loops whuich makes the YAML look a bit "gappy", it was imp to ensure that the environment variables are correctly separated by newlines and don't accidentally mash together into a single invalid line. Valid YAML handles these blank lines without any issues fwiw.