Add needs-release-note label for PRs without release notes#535
Merged
Conversation
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".github/workflows/label.yaml">
<violation number="1" location=".github/workflows/label.yaml:71">
P1: Release-note check is unreachable when any label-sync rule fails. The `throw` on the preceding line aborts the script before this code runs. Move the release-note block before the aggregated error throw (or into its own try/catch) so it always executes independently.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
gjkim42
reviewed
Mar 3, 2026
Collaborator
gjkim42
left a comment
There was a problem hiding this comment.
label "release-note" to the PR that has a release note.
and label "release-note-none" to the PR that explicitly set "none"(case insensitively) to the PR.
and needs-release-note should be set if either of it does not present
/reset-worker
…or PRs Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ce205c6 to
40a1adc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/kind feature
What type of PR is this?
Feature: Automatically sync release-note labels for PRs based on release note content.
What this PR does / why we need it:
Extends the Label workflow (
.github/workflows/label.yaml) to automatically manage release-note labels on PRs based on the content of therelease-notefenced block in their body. When the PR body is edited, labels are re-evaluated.Changes:
editedtopull_request_targetevent types so the workflow re-evaluates when a PR body is modified```release-notefenced blockrelease-notelabel when the block contains a non-empty, non-NONE release noterelease-note-nonelabel when the block explicitly contains "NONE" (case-insensitive)needs-release-notelabel when the block is missing or emptyWhich issue(s) this PR is related to:
Closes #530
Special notes for your reviewer:
The release-note check only applies to PRs (not issues), matching the same parsing approach used by
hack/release-notes/main.go. The regex/\``release-note\s*\n([\s\S]*?)```/` matches the fenced block and checks content to determine which label to apply.Does this PR introduce a user-facing change?