removed all markup #2702
Open
removed all markup #2702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markup still counts as code imho
|
+1 looks good to me |
mausworks
suggested changes
Nov 20, 2018
mausworks
left a comment
mausworks
left a comment
There was a problem hiding this comment.
I don't agree with this, I think it's important to show where you should not write any code. Otherwise people might write no code in the wrong place.
We don't want that.
|
The purpose of the README doesn't change |
frankli0324
approved these changes
Mar 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
markup still counts as code imho. Sure I like the pretty version, but its still code imho