Skip to content

 #3835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
destasys wants to merge 1 commit into
base: master
Choose a base branch
from
Open

 #3835

destasys wants to merge 1 commit into from
+1 −1

Conversation

@destasys
Copy link

@destasys destasys commented Feb 14, 2020

No description provided.

@destasys
Copy link
Author

destasys commented Feb 14, 2020



@Friz64
Copy link

Friz64 commented Mar 4, 2020

No description provided.

@clrke
Copy link

clrke commented Mar 5, 2020



@igloro
Copy link

igloro commented Mar 5, 2020

No description provided.

@stevefan1999-personal
Copy link

stevefan1999-personal commented Mar 5, 2020

@Nyameliaaaa
Copy link

Nyameliaaaa commented Mar 31, 2020

CIAL

@MrGKanev
Copy link

MrGKanev commented Apr 2, 2020



@Nyameliaaaa
Copy link

Nyameliaaaa commented Apr 2, 2020



@TaQini
Copy link

TaQini commented Apr 2, 2020

@Xanonymous-GitHub
Copy link

Xanonymous-GitHub commented Apr 13, 2020

@Nyameliaaaa
Copy link

Nyameliaaaa commented Apr 17, 2020

h

@gasp
Copy link

gasp commented May 11, 2020



@Crystallinqq
Copy link

Crystallinqq commented May 12, 2020

​

@shakeebshams
Copy link

shakeebshams commented May 15, 2020

@sanan-fataliyev
Copy link

sanan-fataliyev commented May 21, 2020

​

@jpalmieri
Copy link

jpalmieri commented Jun 29, 2020

L TM

@kmou424
Copy link

kmou424 commented Jul 12, 2020



@sabbyX
Copy link

sabbyX commented Jul 17, 2020

​

@keinsell
Copy link

keinsell commented Jul 23, 2020

@keinsell
Copy link

keinsell commented Jul 23, 2020


@keinsell
Copy link

keinsell commented Jul 23, 2020

@liquidhelium
Copy link

liquidhelium commented Jul 27, 2020

@jasonliang-dev
Copy link

jasonliang-dev commented Aug 6, 2020


keinsell
keinsell approved these changes Aug 6, 2020
View reviewed changes
Copy link

@keinsell keinsell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Let's push that shit to production!

@quackduck
Copy link

quackduck commented Feb 11, 2021

I think this is ready to merge now.

quackduck
quackduck approved these changes Feb 11, 2021
View reviewed changes
Copy link

@quackduck quackduck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

‍

Vendicated
Vendicated reviewed Feb 20, 2021
View reviewed changes
Copy link

@Vendicated Vendicated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

​

Vendicated
Vendicated approved these changes Feb 20, 2021
View reviewed changes
Copy link

@Vendicated Vendicated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

​

@Hocuri
Copy link

Hocuri commented Feb 21, 2021

‎

Hocuri
Hocuri approved these changes Mar 27, 2021
View reviewed changes
Copy link

@Hocuri Hocuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

‎

ghost
ghost approved these changes Apr 12, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chosenvictim
Copy link

chosenvictim commented Apr 14, 2021

LGTM. Ship it!!

@vitalymak
Copy link

vitalymak commented May 11, 2021

@Bramgus12
Copy link

Bramgus12 commented Sep 4, 2021

@AnthonyDugarte
Copy link

AnthonyDugarte commented Apr 7, 2022

LGTM

aspearman
aspearman suggested changes Jul 2, 2022
View reviewed changes
Copy link

@aspearman aspearman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too much code

Dockerfile
@@ -1 +1 @@
FROM scratch
FROM scratch No newline at end of file
Copy link

@aspearman aspearman Jul 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to

Copy link

@ephraimduncan ephraimduncan Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sbrantq
sbrantq approved these changes Jul 6, 2022
View reviewed changes
Copy link

@sbrantq sbrantq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saikumar1607
Copy link

saikumar1607 commented Mar 1, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kelseyhightower kelseyhightower Awaiting requested review from kelseyhightower

25 more reviewers

@ephraimduncan ephraimduncan ephraimduncan left review comments

@aspearman aspearman aspearman requested changes

@hsh2001 hsh2001 hsh2001 approved these changes

@linhnq-1077 linhnq-1077 linhnq-1077 approved these changes

@tikazyq tikazyq tikazyq approved these changes

@Hocuri Hocuri Hocuri approved these changes

@zjoh5253 zjoh5253 zjoh5253 approved these changes

@yardenshoham yardenshoham yardenshoham approved these changes

@hasan-yaman hasan-yaman hasan-yaman approved these changes

@facuparedes facuparedes facuparedes approved these changes

@JBaczuk JBaczuk JBaczuk approved these changes

@conradkirschner conradkirschner conradkirschner approved these changes

@AndreasNel AndreasNel AndreasNel approved these changes

@Spikatrix Spikatrix Spikatrix approved these changes

@bnimam bnimam bnimam approved these changes

@quackduck quackduck quackduck approved these changes

@keinsell keinsell keinsell approved these changes

@Vendicated Vendicated Vendicated approved these changes

@drendog drendog drendog approved these changes

@byeze byeze byeze approved these changes

@cycleccc cycleccc cycleccc approved these changes

@sbrantq sbrantq sbrantq approved these changes

@me-when-the-uh me-when-the-uh me-when-the-uh approved these changes

@nrailuj nrailuj nrailuj approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.