fix(ci): run publint/attw from package dir so the release workflow works#14
Merged
fix(ci): run publint/attw from package dir so the release workflow works#14
Conversation
The release workflow called `pnpm --filter plainfp dlx publint`, but `pnpm dlx` ignores filter flags and rejects `--recursive`, so the step failed with `ERROR Unknown option: 'recursive'` and the v0.1.0 publish never reached npm. Switch to a `working-directory: packages/plainfp` step that runs both publint and @arethetypeswrong/cli in the same place we run them from CI `Build + publint`. Matches the pattern already used by the `Publish with provenance` and `Create GitHub Release` steps below. No runtime change, just a workflow fix.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14 +/- ##
=======================================
Coverage 91.68% 91.68%
=======================================
Files 23 23
Lines 397 397
Branches 90 90
=======================================
Hits 364 364
Misses 11 11
Partials 22 22
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The v0.1.0 release workflow failed before reaching npm. The publint step was written as:
But
pnpm dlxignores filter flags and actively rejects--recursive(which-r/--filterintroduces into its options), so the step fails with:Fix
Run the packaging-hygiene checks from the package's own directory via
working-directory:, same pattern already used by the publish + GitHub Release steps below. Also add theattwcheck thatci.ymlruns — release should verify the same packaging quality gates.Verified locally
Ran the full release sequence locally against `packages/plainfp` at 0.1.0:
pnpm publish --dry-runRecovery for v0.1.0
Once this merges, I'll delete the failed tag and re-tag from the new main:
git tag -d v0.1.0 git push --delete origin v0.1.0 git checkout main && git pull git tag v0.1.0 git push --tagsThe tag push fires
release.yml(with the fix) → publishes with provenance + creates the GitHub Release.Test plan