ci: fix CodSpeed integration and switch to OIDC auth#2
Closed
codspeed-hq[bot] wants to merge 1 commit intomainfrom
Closed
ci: fix CodSpeed integration and switch to OIDC auth#2codspeed-hq[bot] wants to merge 1 commit intomainfrom
codspeed-hq[bot] wants to merge 1 commit intomainfrom
Conversation
Owner
|
Applied equivalent changes manually in f9077da to keep contributors as humans. Thanks for catching the wrong SHA + the OIDC tip! |
kelsos
added a commit
that referenced
this pull request
Apr 18, 2026
Update the API map table in packages/plainfp/README.md so the Result and Option rows reflect what the barrels actually export. Result now lists: tap, tapError, toOption (added in batch #1 and #2). Option now lists: tap, tapNone, all, any, zip, toResult (same). Verified every listed symbol against packages/plainfp/src/<namespace>/index.ts; result-async / arrays / records / strings / predicates / functions / brand / non-empty-array / tagged / interop/zod rows were already correct.
kelsos
added a commit
that referenced
this pull request
Apr 18, 2026
Update the API map table in packages/plainfp/README.md so the Result and Option rows reflect what the barrels actually export. Result now lists: tap, tapError, toOption (added in batch #1 and #2). Option now lists: tap, tapNone, all, any, zip, toResult (same). Verified every listed symbol against packages/plainfp/src/<namespace>/index.ts; result-async / arrays / records / strings / predicates / functions / brand / non-empty-array / tagged / interop/zod rows were already correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the existing CodSpeed benchmarking setup and improves the CI integration.
Changes
CI workflow fixes (
.github/workflows/ci.yml):76578c2a7...) pointed to v3.8.1, not v4.13.1 as the comment stated. Updated to the correct v4.13.1 commit (db35df748...).token: ${{ secrets.CODSPEED_TOKEN }}parameter. The workflow already hasid-token: writepermission, so OIDC authentication works out of the box without needing a secret.mode: simulation: Explicitly sets the CodSpeed instrument to CPU simulation mode, which provides deterministic, noise-free measurements with less than 1% variance.workflow_dispatchtrigger: Enables CodSpeed to trigger backtest analysis for generating initial baseline data.README badge: Added CodSpeed performance badge to the repository README.
Existing benchmark coverage
The repository already has well-structured benchmarks covering core functionality:
pipe.bench.ts-- pipe vs manual function chainingarrays/transform.bench.ts-- map, filter, flatMap vs native, plus dual-API (data-first vs curried) overheadresult/transform.bench.ts-- Result.map/flatMap vs try/catch error handling patternsNext steps
maincompletes, CodSpeed will have baseline data and will automatically report performance changes on future pull requests.Note: since
kelsosis a personal GitHub account,codspeed-macrorunners are not available. The benchmarks run on standardubuntu-latestrunners. This means walltime measurements would have significantly higher variance -- which is why this setup usessimulationmode instead, providing deterministic results regardless of the runner hardware. For more details, see the walltime docs.