Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #732
Problem
Currently request body IO can only be consumed once. When multiple handlers need the body (e.g. kemal-session for CSRF, kemal-controller for params), the second handler gets an empty body.
Solution
Add a public
raw_bodymethod toParamParserthat reads and caches the body on first access. Bothparse_bodyandparse_jsonnow use this cached value, so multiple handlers can access the body viaenv.params.raw_bodywithout consuming the IO.Changes
raw_bodytoParamParser(caches forapplication/x-www-form-urlencodedandapplication/json)parse_bodyandparse_jsonto useraw_bodyinstead of reading directly from@request.bodyparse_filesstill streams viaHTTP::FormData.parseUsage