Reset restart_count for host-network workers stuck in Creating with a live container#185
Merged
Merged
Conversation
5196d14 to
d651dca
Compare
d651dca to
8a859ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A worker in
network: hostmode can never satisfy Ring's readiness checks (its container has no resolvable address), so it staysCreatingfor its entire life even though its container runs fine.The anti-flap window that refills
restart_countonly reset the count when the deployment reachedRunning. A host-network worker therefore accumulated a monotonicrestart_count: its retry backoff climbed to the 60s cap and never came back down. Every redeploy got progressively slower (observed: ~5 min to recreate a container after a drop).Fix
Treat a deployment as healthy-running for the anti-flap window whenever it actually has a live container, not only when it reached
Running:Running, orCreatingwith a non-empty instance list. Extracted into a small purehas_live_container()helper.Impact
Measured in production after deploying this fix: container recreation after a drop dropped from ~5 min to ~20s.
Tests
Added 4 unit tests covering
has_live_container(Running, Creating+instance, Creating without instance, other states). Full suite: 735 passed.