Skip backend creation for pure-redirect entrypoints#118
Merged
Conversation
Shine-neko
force-pushed
the
fix/no-backend-for-pure-redirect
branch
from
3489ecb to
67c26a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An entrypoint whose redirect policy is
permanentorunauthorizedanswers at the frontend and never forwards to a backend. Today the parser still attaches aBackendto it, which registers a phantom backend the health checker then probes forever — and if the entrypoint declares no.port, that backend falls back to:80where nothing listens, so it's reported unhealthy indefinitely and pollutes the cluster's backend set.This skips backend creation when the redirect policy is
PermanentorUnauthorized. Forwarding redirects still proxy, so they keep their backend.Covered by the existing parser tests (25 passing);
cargo fmtandclippyclean.