Skip to content

Improve source helper test coverage#9

Merged
kemsta merged 5 commits intomainfrom
dynamic_engine
Mar 9, 2026
Merged

Improve source helper test coverage#9
kemsta merged 5 commits intomainfrom
dynamic_engine

Conversation

@kemsta
Copy link
Copy Markdown
Owner

@kemsta kemsta commented Mar 9, 2026

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR factors common ScreenCaptureKit helper logic (item selection and audio buffer normalization) into a shared internal module and adds unit tests to improve coverage across the source implementations.

Changes:

  • Add sources::screen_capture with shared helpers for selecting items by id(s) and normalizing audio buffers, including dedicated unit tests.
  • Refactor app_audio and system_audio to use the shared helpers and add unit tests for display/application selection behavior.
  • Extract microphone config validation into a helper and add a focused test; adjust cli_tester logging/stats printing.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
core_engine/src/sources/system_audio.rs Uses shared selection/audio normalization helpers; adds selection tests.
core_engine/src/sources/screen_capture.rs New internal helper module with selection + normalization logic and tests.
core_engine/src/sources/mod.rs Registers the new internal screen_capture module.
core_engine/src/sources/microphone.rs Extracts config validation into helper + adds a test.
core_engine/src/sources/app_audio.rs Uses shared selection/audio normalization helpers; adds selection tests.
cli_tester/src/main.rs Adds extra case-flow prints; updates stats field access (currently incorrect).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread core_engine/src/sources/app_audio.rs
Comment thread core_engine/src/sources/system_audio.rs
Comment thread cli_tester/src/main.rs Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kemsta kemsta merged commit 4031581 into main Mar 9, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants