Support for different model structures #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
May 15, 2017 14:23
kencoken
reviewed
May 19, 2017
keras/utils/layer_utils.py
Outdated
| # Remove layer class from custom_objects as it's not needed anymore | ||
| custom_objects.pop('layer_class', None) | ||
| for cls_key in custom_objects: | ||
| globals()[cls_key] = custom_objects[cls_key] |
Owner
There was a problem hiding this comment.
Tried to figure this out but wasn't 100% clear to me... why do we need to dump the custom_objects in the global variable space here?
keras/models.py
Outdated
| training_config = f.attrs.get('training_config') | ||
| if training_config is None: | ||
| if training_config is None or ('classify' in custom_objects and custom_objects['classify']): | ||
| custom_objects.pop('layer_class', None) |
Owner
There was a problem hiding this comment.
Why do we pop layer_class here?
kencoken
approved these changes
May 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for different model structures