Remove built-in chat command in favor of MCP server#18
Merged
Conversation
The built-in chat command (RAG over Ollama) took on too much responsibility: LLM integration, prompt engineering, streaming, and retrieval logic. The MCP server already exposes the full search/query/read interface, so any MCP-capable client (Claude Desktop, OpenWebUI, etc.) can do this better. Removes: - internal/chat/ package (chat.go, llm.go, prompt.go, tests) - cmd chat.go CLI command - ChatConfig from config - ollama dependency from go.mod Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The built-in
msgvault chatcommand implemented RAG (retrieval-augmented generation) over a local Ollama instance. While it worked, it was underbaked and took on responsibilities that don't belong in an archival tool: LLM client management, prompt engineering, streaming output, and retrieval orchestration.Meanwhile, the MCP server (
msgvault mcp) already exposes the full archive — search, aggregates, message detail, metadata — as a standard protocol that any AI client can use. This is a better architecture:Maintaining a bespoke chat implementation alongside MCP means duplicated effort for a worse result. Removing it lets us focus on making the MCP server excellent.
What changed
internal/chat/package (RAG session, Ollama client, prompts, tests)cmd/msgvault/cmd/chat.goCLI commandChatConfigfrom config and[chat]section defaultsgithub.com/ollama/ollamadependency (~914 lines removed)Test plan
make buildpassesmake testpassesmake lintpassesmsgvault --helpno longer showschatcommand🤖 Generated with Claude Code