This repository was archived by the owner on Feb 6, 2025. It is now read-only.
Tests for UUID inequality filters ('>=', '>'...) #482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bojanserafimov
approved these changes
Aug 16, 2019
bojanserafimov
pushed a commit
that referenced
this pull request
Aug 19, 2019
* Add uuid filtering support
* Add assertion, improve docstrings
* Change error type
* Improve docstrings
* Document UUID constants
* Remove function querying parameters dict
* Address most reviewer feedback
* Address comments. Major revamp
* Delint
* Improve intersection finding for IntegerIntervals
* Change disjoint intersection handling
* Remove test modifications
* Improve documentation for intersection finding
* Slight changes
* Accidental test changes, reverting
* Address comments, improve error handling
* Improve error handling
* Improve docstring situation
* Further improve docstring situation
* Fix lingering intervals mention
* Remove optional
* Improve error handling, document it as well
* Add note for why between and equivalent pair of >=/<= filters are handled differently
* Add more helpful note
* Final few docstring changes
* Address comments
* Tests for UUID inequality filters ('>=', '>'...) (#482)
* Add tests for uuid filtering
* Delint
* Add intersection testing, change from CostEstimation tests to FilterSelectivityTests
* Delint x2
* Make tests reflect reviewer feedback
* Delint, add new test
* Nit
* Slight comment tweaks
* Remove unimportant file
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's the tests that check that UUID inequality filters are handled properly.
Test plan:
In
CostEstimationTests, a generic inequality filter is applied just to sanity-check that the filter estimates actually reflect in the cost estimates.In
FilterSelectivityUtilsTests, a few tests are added intest_inequality_filters_on_uuid.betweenfilter over a quarter of UUID-space is checked.>=and<=over a quarter of UUID-space is checked. Here, we test the fact that the>=and<=filters are independent of one another. Although this filter is equivalent to the 'between' filter above, our assumption that filters are independent of one another forces us to consider them differently.Another test class is also added,
IntegerIntervalTests, that make sure_create_integer_intervaland intersections of intervals are handled correctly, as the code there is fairly tricky.