Skip to content

Conversation

@arnavb
Copy link
Contributor

@arnavb arnavb commented Sep 5, 2018

(Put an X inside the [ ] to denote check mark [X].)

  • If creating a new file :

    • added links to it in the README files ?
    • included tests with it ?
    • added description (overview of algorithm, time and space compleixty, and possible edge case) in docstrings ?
  • if done some changes :

    • wrote short description in the PR explaining what the changes do ?
      There is an if not array check in search_rotate.py, even when this is not necessary because the code would not enter the while loop anyway if the size of the array is 0.
    • Fixes #[issue number] if related to any issue
  • other

@coveralls
Copy link

Pull Request Test Coverage Report for Build 739

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 71.464%

Files with Coverage Reduction New Missed Lines %
algorithms/sort/top_sort.py 2 90.38%
Totals Coverage Status
Change from base Build 737: -0.03%
Covered Lines: 4300
Relevant Lines: 6017

💛 - Coveralls

@keon keon merged commit 4f8ccdd into keon:master Sep 5, 2018
@arnavb arnavb deleted the arnavb-patch-2 branch September 5, 2018 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants