Skip to content

Conversation

@holisound
Copy link

@holisound holisound commented Sep 15, 2018

(Put an X inside the [ ] to denote check mark [X].)

  • If creating a new file :

    • added links to it in the README files ?
    • included tests with it ?
    • added description (overview of algorithm, time and space compleixty, and possible edge case) in docstrings ?
  • if done some changes :

    • wrote short description in the PR explaining what the changes do ?
    • Fixes #[issue number] if related to any issue
  • other

@coveralls
Copy link

coveralls commented Sep 15, 2018

Pull Request Test Coverage Report for Build 744

  • 16 of 16 (100.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.08%) to 71.627%

Files with Coverage Reduction New Missed Lines %
algorithms/linkedlist/is_palindrome.py 1 93.33%
Totals Coverage Status
Change from base Build 742: 0.08%
Covered Lines: 4322
Relevant Lines: 6034

💛 - Coveralls

@goswami-rahul
Copy link
Collaborator

Hi! Sorry for late response. Can you please explain what your algorithm is doing and also rename it and save as some descriptive name with explainations? Thanks.

@holisound
Copy link
Author

Hi, my algorithm is another solution to the arrays problem top 1, which
counting elements and updating the result during once iteration. Comparing with the available solution, I think it will be more efficient.

@holisound holisound closed this Oct 11, 2018
@holisound holisound deleted the add_top_1_dp branch October 11, 2018 02:57
@holisound holisound restored the add_top_1_dp branch October 11, 2018 03:01
@keon
Copy link
Owner

keon commented Oct 12, 2018

@edwardw1987 why did you close this PR?

@holisound
Copy link
Author

Hi, Keno
It's superised to catch your message!
The project you launched is really cool and awesome.
I am a python developer who has been interested in algorithm, but I didn't find a right way to contribute code snippets. (my first pull request)
Sorry for the closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants