Add diffie hellman key exchange #615
Conversation
…diffie_hellman_key_exchange
…diffie_hellman_key_exchange Update local branch with master branch
|
To implement DH key exchange, prime_check.py (written by 'goswami-rahul' and 'Hai Honag Dang') and euler_totient function (written by 'goswami-rahul') is needed. Again, Please let me know if such usage is problematic. |
| print ("Private key of Alice = %d" % a_pr_k) | ||
| print ("Public key of Alice = %d" % a_pu_k) |
There was a problem hiding this comment.
could you make the print statements optional?
There was a problem hiding this comment.
[Edit] Add optional parameter, and those statements only appears when that parameter is given.
I left shared-key print statements for comparison.
Do you think those statements should be optional also?
Please let me hear your opinion. Thanks.
| p_root_list.index(a) | ||
| except ValueError as e: | ||
| print("%d is not a primitive root of %d" % (a, p)) | ||
| return -1 |
There was a problem hiding this comment.
please raise error in this case so we can only return bool type.
If a function returns two types (-1, bool) the caller needs to branch out by the return type.
There was a problem hiding this comment.
[Edit] For primitive root case, code now return False, for consistency
Merge branch 'master' of https://github.com/keon/algorithms into add_diffie_hellman_key_exchange
…tency (return Bool only)
…diffie_hellman_key_exchange
|
thanks so much for the contribution! |
2 participants
(Put an
Xinside the[ ]to denote check mark[X].)If creating a new file :
if done some changes :
other