Add two more breaking bad tests #636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Tests are okay, but I think the cases should be added on the |
ericklarac
approved these changes
Feb 25, 2020
Owner
|
@ericklarac feel free to merge yourself :) |
Collaborator
|
@keon Thanks, actually I thought you have to review it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two more tests to
bracket(words, symbols)function instrings/breaking_bad.py. Adding these tests results in 100% branch coverage for the function.Test 1: Test to match symbols that do not exist in the word list. This should return the words without any changes made to them.
Test 2: Try to match two duplicate symbols. It should only encapsulate the match once ([i]), not twice ([[i]]).