Skip to content

Conversation

@c-utkarsh
Copy link
Contributor

No description provided.

@@ -1 +1 @@

from .matrix_exponentiation import *
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this. multiply collides with multiply.py.

if __name__ == "__main__":
mat = [[1, 0, 2], [2, 1, 0], [0, 2, 1]]

res0 = matrix_exponentiation(mat, 0)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add tests at tests/test_matrix.py similar to other tests.

@c-utkarsh
Copy link
Contributor Author

Hi @goswami-rahul, I've incorporated the requested changes.

Copy link
Collaborator

@goswami-rahul goswami-rahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM

@goswami-rahul goswami-rahul merged commit d04b9a5 into keon:master Oct 4, 2020
@c-utkarsh c-utkarsh deleted the add_matrix_exponentiation branch October 6, 2020 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants