Merged
Conversation
Add updated analytics script to improve site usage tracking. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Code Review SummaryStatus: No Issues Found | Recommendation: Merge OverviewThe PR adds a telemetry script configuration to
The configuration is straightforward and correctly structured. Files Reviewed (1 file)
Reviewed by claude-4.5-opus-20251124 · 60,910 tokens |
2 tasks
There was a problem hiding this comment.
Pull request overview
Aligns the newly added telemetry script configuration with the existing Docusaurus scripts loading pattern to ensure consistent script execution behavior across the docs site.
Changes:
- Adds
defer: trueto thehttps://telemetry.keploy.io/sessions/sdk.jsscript entry to match other scripts indocusaurus.config.js.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Dhananjay Aggarwal <133662894+dhananjay6561@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR addresses the review comments raised on #807 by resolving script loading consistency and supply-chain risk concerns flagged for the telemetry script added to
docusaurus.config.js.Problem
The telemetry script entry added in #807 was missing the
defer: trueattribute, making it inconsistent with all other script entries in thescriptsarray (feedback.js,clarity.js,apollo-init.js), which all specify bothasync: trueanddefer: true. This inconsistency could affect script execution order and page load behavior.Solution
Added
defer: trueto the telemetry script configuration to align with the existing script loading pattern across the Docusaurus config.Regarding the SRI (
integrity+crossorigin) suggestion — sincetelemetry.keploy.iois an owned domain and not a true third-party source, the supply-chain risk is minimal. Adding SRI would require manually updating the hash on every SDK update, introducing maintenance overhead and risk of silently breaking analytics on the docs site. This has been consciously deferred.Files Changed
docusaurus.config.js— Addeddefer: trueto thetelemetry.keploy.io/sessions/sdk.jsscript entry.