Add nil check for expected & actual type#22
Merged
gouravkrosx merged 2 commits intokeploy:mainfrom May 8, 2025
Merged
Conversation
|
To generate Unit Tests for this PR, please click here |
There was a problem hiding this comment.
Pull Request Overview
This PR aims to fix a nil pointer panic in the JSON diff comparison by enhancing error messages and adding an explicit nil check for the JSON type information.
- Enhanced error reporting for JSON unmarshal failures
- Introduced a nil check for type information to ensure safe type comparisons
Member
|
@harshitashankar can you please check the failing test ? |
Contributor
Author
|
harshitashankar
force-pushed
the
nilcheck-comparejson
branch
3 times, most recently
from
cb4ec8e to
602959a
Compare
Signed-off-by: Harshita Shankar <harshitashankar@yahoo.com>
harshitashankar
force-pushed
the
nilcheck-comparejson
branch
from
602959a to
7af58de
Compare
Signed-off-by: Harshita Shankar <harshitashankar@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue desc
Keploy stopped with nil pointer panic when tests were being replayed
Keploy used from https://github.com/harshitashankar/keploy/tree/main-4may-sync branch (w/o this change in jsondiff)
Error screenshot
This change fixes nil pointer error in jsondiff code. Verified that tests are successfully replayed with this change in jsondiff