Feature/issue 38 unit tests#39
Merged
Merged
Conversation
Added 34 new tests across all 4 test files: - Headers: lowercase key normalization, tab/newline stripping, multi-Received join, AbuseIPDB link, spoof check fields, display-name+angle-bracket From, raw values preserved on failure - Links: sequential indexing, empty href filtering, http:// extraction, duplicate deduplication, http:// protocol stripping in investigation, URLScan domain check, QP investigation mode, no-links investigation empty - Digests: lowercase hex validation, MD5/SHA256 direct computation match, independent file vs content hash paths, different files produce different hashes, investigation count matches data count - Attachments: indexed from "1", count validation, SHA256/MD5 direct computation match, hash determinism, different attachments differ, all 3 hashes per attachment, investigation count matches, no-attachment investigation empty
Added 25 tests (80 → 105): minimal email handling, exact VT/AbuseIPDB/ URLScan URL format assertions, investigation key isolation, single link extraction, query params and fragment preservation, triple-duplicate dedup, SHA1 direct computation match for digests and attachments, hashes verified on multiple fixtures, image attachment support, sequential multi-attachment indexing, and exact VT URL format for attachments. Added 4 new fixtures: minimal.eml, single_link.eml, links_with_params.eml, image_attachment.eml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unit tests added.