Fix the unit test for segmentation head serialization. #882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure why the unit test didn't catch it in keras-team#875. All the test check was passing.
Member
Author
|
/gcbrun |
ianstenbit
approved these changes
Oct 5, 2022
Contributor
ianstenbit
left a comment
ianstenbit
left a comment
There was a problem hiding this comment.
It might be worth digging into why our CI didn't catch this. From looking at the logs, it seems like the serialization test is run, so I'm not certain what happened.
ghost
pushed a commit
to y-vectorfield/keras-cv
that referenced
this pull request
Nov 16, 2023
Not sure why the unit test didn't catch it in keras-team#875. All the test check was passing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Not sure why the unit test didn't catch it in #875. All the test check was passing.
Before submitting
Pull Request section?
to it if that's the case.