Skip to content

Conversation

@sunny7712
Copy link

@rkazants kindly review this. Let me know if there's any changes to be made. Thanks!

@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2025

Codecov Report

Attention: Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.

Project coverage is 80.12%. Comparing base (d865f5f) to head (28bab0a).
Report is 20 commits behind head on master.

Files with missing lines Patch % Lines
keras/src/backend/openvino/numpy.py 0.00% 30 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21071      +/-   ##
==========================================
- Coverage   82.65%   80.12%   -2.54%     
==========================================
  Files         563      564       +1     
  Lines       53975    54162     +187     
  Branches     8386     8419      +33     
==========================================
- Hits        44615    43396    -1219     
- Misses       7291     8749    +1458     
+ Partials     2069     2017      -52     
Flag Coverage Δ
keras 79.93% <0.00%> (-2.54%) ⬇️
keras-jax 64.04% <0.00%> (+0.03%) ⬆️
keras-numpy 59.06% <0.00%> (-0.01%) ⬇️
keras-openvino ?
keras-tensorflow 64.33% <0.00%> (-0.01%) ⬇️
keras-torch 64.08% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gbaned gbaned added this to PR Queue Mar 25, 2025
@github-project-automation github-project-automation bot moved this to Assigned Reviewer in PR Queue Mar 25, 2025
@gbaned gbaned requested a review from mattdangerw March 25, 2025 07:26
@rkazants
Copy link
Contributor

@sunny7712, please fix tests in CI:

FAILED keras/src/ops/numpy_test.py::NumpyOneInputOpsCorrectnessTest::test_argmax - TypeError: topk() missing 1 required positional argument: 'sort'
FAILED keras/src/ops/numpy_test.py::NumpyOneInputOpsCorrectnessTest::test_argmin - TypeError: topk() missing 1 required positional argument: 'sort'
...

@rkazants
Copy link
Contributor

rkazants commented Apr 9, 2025

@sunny7712, please close PR because it was implemented and merged in another PR.

Thanks,
Roman

@sunny7712 sunny7712 closed this Apr 11, 2025
@github-project-automation github-project-automation bot moved this from Assigned Reviewer to Closed/Rejected in PR Queue Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Closed/Rejected

Development

Successfully merging this pull request may close these issues.

4 participants