feat: add Pool column to browsers list#117
Conversation
Show pool_id in the browser list table for browsers acquired from a pool. Extracts pool_id from SDK ExtraFields until the SDK is regenerated with the new field. Related: kernel/kernel#1286 Co-authored-by: Cursor <cursoragent@cursor.com>
f866b7c to
34d1e41
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
|
🔧 CI Fix Available I've pushed a fix for the CI failure. The issue was that the The fix removes the replace directive and uses the SDK's |
Sayan-
left a comment
There was a problem hiding this comment.
changes lgtm - one suggestion. once we publish the new sdk please re-request review and we'll 🚢
Update browser list to display pool name (falling back to pool ID) using the new structured pool object from the API response. Co-authored-by: Cursor <cursoragent@cursor.com>
|
changes lgtm! once we release and update the sdk dep I'll approve |
Remove the replace directive pointing to github.com/stainless-sdks/kernel-go and upgrade github.com/kernel/kernel-go-sdk from v0.37.0 to v0.40.0. Co-authored-by: Mason Williams <masnwilliams@users.noreply.github.com>
Summary
kernel browsers listtable output showing the pool ID for browsers acquired from a pool (or "-" for regular browsers)pool_iduntil the Go SDK is regenerated with the new fieldDepends on kernel/kernel#1286 for the API to return
pool_id.Test plan
kernel browsers listwith pooled browsers shows pool ID in Pool columnkernel browsers listwith regular browsers shows "-" in Pool columnkernel browsers list --output jsonincludespool_idfor pooled browsersMade with Cursor
Note
Low Risk
Low risk: CLI-only output change plus a minor SDK version bump; the main impact is altered table columns/order and reliance on the updated SDK response shape for
Pool.Overview
Adds a new "Pool" column to
kernel browsers listtable output, populating it frombrowser.Pool(name preferred, then ID, else-).Bumps
github.com/kernel/kernel-go-sdkfromv0.39.0tov0.40.0(with correspondinggo.sumupdates) to support the new field in list responses.Written by Cursor Bugbot for commit 835d46a. This will update automatically on new commits. Configure here.