Add env vars, clean up ux, and set-up automated npm publishing #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juecd
commented
May 19, 2025
| { | ||
| "name": "@onkernel/create-kernel-app", | ||
| "version": "0.1.3", | ||
| "version": "0.1.5", |
Contributor
Author
There was a problem hiding this comment.
I published 0.1.4 from my local without committing, which is why we're skipping 4
mertcelebi
approved these changes
May 19, 2025
.github/workflows/publish.yml
Outdated
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '18' |
There was a problem hiding this comment.
nit: any reason why this is so old? we're at 21 rn and i think the sdk is at 20
| task: str | ||
| openai_api_key: str | ||
|
|
||
| # LLM API Keys are set in the environment during `kernel deploy <filename> --env OPENAI_API_KEY=XXX` |
There was a problem hiding this comment.
I am kinda curious: what happens if my python project that is getting zipped has a .env file that is loaded with load_env? Does that overwrite this?
There was a problem hiding this comment.
(not a blocker for this pr, am curious)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.