Fix proxy lookup fallthrough on missing retrieve id

Author: cursoragent

packages/cli/src/harness-browser.ts

@@ -65,7 +65,10 @@ export async function resolveProxyId(client: Kernel, selector: string): Promise<
 	if (!trimmed) throw new Error("proxy selector is empty");
 	try {
 		const existing = await client.proxies.retrieve(trimmed);
-		if (existing.id) return existing.id;
+		if (!existing.id) {
+			throw new Error(`proxy "${trimmed}" lookup returned no id`);
+		}
+		return existing.id;
 	} catch (err) {
 		if (!(err instanceof NotFoundError)) {
 			throw new Error(`looking up proxy "${trimmed}": ${(err as Error).message}`, { cause: err });

packages/cli/test/harness-browser.test.ts

@@ -22,6 +22,19 @@ describe("resolveProxyId", () => {
 		await expect(resolveProxyId(client, "proxy_abc")).resolves.toBe("proxy_abc");
 	});
 
+	it("does not fall back to name matching when retrieve succeeds without an id", async () => {
+		let listCalled = false;
+		const client = fakeClient({
+			retrieve: async () => ({}),
+			list: async () => {
+				listCalled = true;
+				return [{ id: "proxy_1", name: "proxy_abc" }];
+			},
+		});
+		await expect(resolveProxyId(client, "proxy_abc")).rejects.toThrow(/looking up proxy/);
+		expect(listCalled).toBe(false);
+	});
+
 	it("falls back to a unique name match from the proxy list", async () => {
 		const client = fakeClient({ list: async () => [{ id: "proxy_1", name: "residential-us" }, { id: "proxy_2", name: "other" }] });
 		await expect(resolveProxyId(client, "residential-us")).resolves.toBe("proxy_1");