-
Notifications
You must be signed in to change notification settings - Fork 7
change copy prompt button hover to underline #330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+4
−5
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
f5e30a8
change copy prompt button hover from bg color to underline
masnwilliams 6e3f46a
add static placeholder for copy prompt button to prevent late loading…
masnwilliams 41d71e8
Revert "add static placeholder for copy prompt button to prevent late…
masnwilliams File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Transition on non-animatable text-decoration-line is ineffective
Low Severity
The
transition: 'text-decoration 0.15s ease'declaration is dead code. CSS cannot transitiontext-decoration-line(which is what changes betweennoneandunderline). Onlytext-decoration-colorandtext-decoration-thicknessare animatable sub-properties. The underline will still appear and disappear on hover, but it snaps instantly with no smooth transition, making this line misleading.Reviewed by Cursor Bugbot for commit f5e30a8. Configure here.