Add CloudFormation benchmark options#237
Open
rgarcia wants to merge 1 commit into
Open
Conversation
|
Firetiger deploy monitoring skipped This PR didn't match the auto-monitor filter configured on your GitHub connection:
Reason: Changes are limited to CloudFormation templates and AWS deployment configuration, not to API endpoints or Temporal workflows. To monitor this PR anyway, reply with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
Note
Medium Risk
Moderate risk because it changes EC2 launch configuration (block device mappings now created via a custom launch template) and adds new optional inbound network exposure, which can affect instance replacement and security group behavior.
Overview
Adds optional CloudFormation parameters to open HTTP (80) and HTTPS (443) ingress (guarded by
UseHttpIngress/UseHttpsIngress) from a newAllowedIngressCidr, alongside the existing API/SSH rules.Introduces
DataVolumeIopsandDataVolumeThroughputknobs for the gp3 data EBS volume, and moves both root/data block device mappings into the custom launch-template Lambda so gp3 throughput and nested virtualization are configured together.Updates the Go contract tests to cover the new parameters, conditional ingress rules, and the expanded launch template payload/properties.
Reviewed by Cursor Bugbot for commit a806d21. Bugbot is set up for automated code reviews on this repo. Configure here.