Conversation
There was a problem hiding this comment.
Performed full review of 0dbee0f...8a4c3c9
Analysis
-
The PR only mentions adding "http" and "https" protocol options, which may be limiting if other proxy protocols are needed in the future (like SOCKS5 or FTP).
-
There's no indication of backward compatibility handling - how will existing clients that don't specify a Protocol field behave? A default value or graceful fallback should be clear.
-
While the PR updates test cases, there's no mention of specific error handling for invalid protocol values that might be submitted.
-
The string enum approach for protocols could lead to runtime errors rather than compile-time validation, potentially introducing reliability issues in production.
Tip
⚡ Quick Actions
This review was generated by Mesa.
Actions:
Slash Commands:
/review- Request a full code review/review latest- Review only changes since the last review/describe- Generate PR description. This will update the PR body or issue comment depending on your configuration/help- Get help with Mesa commands and configuration options
7 files reviewed | 0 comments | Review on Mesa | Edit Reviewer Settings
|
🤖 Release is at https://github.com/onkernel/kernel-go-sdk/releases/tag/v0.14.0 🌻 |
Automated Release PR
0.14.0 (2025-10-03)
Full Changelog: v0.13.0...v0.14.0
Features
This pull request is managed by Stainless's GitHub App.
The semver version number is based on included commit messages. Alternatively, you can manually set the version number in the title of this pull request.
For a better experience, it is recommended to use either rebase-merge or squash-merge when merging this pull request.
🔗 Stainless website
📚 Read the docs
🙋 Reach out for help or questions
TL;DR
This release bumps the version to
0.14.0and introduces support for configuring an HTTP proxy.Why we made these changes
This allows the SDK to be used in restricted network environments, such as behind a corporate firewall, where API requests must be routed through a proxy.
What changed?
Validation
Description generated by Mesa. Update settings