[OSS 1/1] Port over the container code from the kernel repo + add OSS docs#1
[OSS 1/1] Port over the container code from the kernel repo + add OSS docs#1mertcelebi merged 6 commits intomainfrom
Conversation
mertcelebi
force-pushed
the
fmc/containers-cleanup
branch
from
997eecf to
700242b
Compare
mertcelebi
force-pushed
the
fmc/containers-cleanup
branch
from
4ff4c00 to
35fe876
Compare
mertcelebi
force-pushed
the
fmc/containers-cleanup
branch
from
b6cf9bf to
f4b4c6d
Compare
mertcelebi
force-pushed
the
fmc/containers-cleanup
branch
from
f4b4c6d to
f4fd432
Compare
CODE_OF_CONDUCT.md
Outdated
|
|
||
| Instances of abusive, harassing, or otherwise unacceptable behavior may be | ||
| reported to the community leaders responsible for enforcement at | ||
| [INSERT CONTACT METHOD]. |
There was a problem hiding this comment.
oh nvm I see you have oss@onkernel.com - that's fine, I'll make that alias
CONTRIBUTING.md
Outdated
| ## Communication | ||
|
|
||
| - GitHub Issues: Bug reports, feature requests, and discussions | ||
| - [Discord](https://discord.gg/Q6WPxeaj): For general questions and community discussions |
There was a problem hiding this comment.
I think that one expired, let's replace it with this (we should do this across the board): https://discord.gg/FBrveQRcud
| @@ -0,0 +1,93 @@ | |||
| # Contributing to Kernel | |||
There was a problem hiding this comment.
Do we need to add CODEOWNERS to this repo? As well as protect main - we can do that after we merge this
There was a problem hiding this comment.
main protection will be in place per the technical plan after we merge all the PRs across the repos. I don't think we need CODEOWNERS for now.
README.md
Outdated
| git clone https://github.com/onkernel/kernel-containers.git | ||
| cd kernel-containers | ||
| docker build -t kernel -f containers/docker/Dockerfile . | ||
| docker build -t kernel -f containers/cu/Dockerfile . |
There was a problem hiding this comment.
Not blocking, but I'm not sure I agree with /cu/ - I assume it's because it's based off Anthropic's Computer Use image? IMO that was more of a prototype quickly decision than a long term one.
There was a problem hiding this comment.
Want just docker? I just copied it from the Kernel repo, I don't mind either way. Feel free to also comment on the DockerHub repo name specified in the action.
There was a problem hiding this comment.
yeah let's just keep it 'docker' - will do on your 2nd point
| - name: Build and push | ||
| uses: docker/build-push-action@v5 | ||
| with: | ||
| context: ./containers/cu |
There was a problem hiding this comment.
prob needs to be updated per our other thread
| push: true | ||
| tags: ${{ secrets.DOCKERHUB_USERNAME }}/kernel-computer-use:${{ github.event.inputs.tag }} | ||
| cache-from: type=registry,ref=${{ secrets.DOCKERHUB_USERNAME }}/kernel-computer-use:buildcache | ||
| cache-to: type=registry,ref=${{ secrets.DOCKERHUB_USERNAME }}/kernel-computer-use:buildcache,mode=max |
There was a problem hiding this comment.
let's call this.... /kernel-chromium
2 participants
This PR: