fix: fall back to --load-extension for extensions missing policy files #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extensions with webRequest permission that are missing update.xml and .crx files were returning 400 errors. This change falls back to the --load-extension approach instead, which works for unpacked extensions created by `kernel extensions download-web-store`. The ExtensionInstallForcelist approach (requiring update.xml + .crx) is still used when those files are present. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Adds a test that verifies extensions with webRequest permission can be loaded via --load-extension even when update.xml and .crx files are missing. The test: 1. Uploads an extension with webRequest permission (no update.xml/.crx) 2. Asserts the upload returns 201 (not 400) 3. Verifies chrome://extensions is accessible after the upload This test would fail before the fix in chromium.go that falls back to --load-extension when ExtensionInstallForcelist files are missing. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
webRequestpermission that are missingupdate.xmland.crxfiles were returning 400 errors--load-extensionapproach instead, which works for unpacked extensions created bykernel extensions download-web-storeExtensionInstallForcelistapproach (requiringupdate.xml+.crx) is still used when those files are presentBackground
The v26 image added validation requiring extensions with
webRequestpermission to haveupdate.xmland.crxfiles forExtensionInstallForcelist. However, the kernel CLI'sdownload-web-storecommand creates unpacked extensions without these files, causing extension loading to fail.This fix allows falling back to the
--load-extensionflag approach when the policy files are missing, which is how v25 handled these extensions.Test plan
TestWebRequestExtensionFallbacke2e testwebRequestpermission but noupdate.xml/.crx🤖 Generated with Claude Code
Note
Allows unpacked extensions that trigger enterprise policy to load without
update.xml/.crxby falling back to Chromium--load-extensionflags.UploadExtensionsAndRestart, when an extension requires policy but is missingupdate.xmlor a.crx, log and disable policy install, appending its path to--disable-extensions-except/--load-extensioninstead of returning 400update.xmlwhen presentTestWebRequestExtensionFallbackand a minimaltest-extension-webrequest(MV3,webRequest) to assert 201 response and basic chrome://extensions accessibilityWritten by Cursor Bugbot for commit 569e408. This will update automatically on new commits. Configure here.