Use absolute path for ./tmp/chromium/flags #37
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running Docker locally requires an absolute path for
.tmp/chromium/flags"TL;DR
Updated
run-docker.shto use an absolute path for Chromium flags, fixing local Docker execution.Why we made these changes
Local Docker setup for Chromium failed because the flags file was not found without an absolute path.
What changed?
FLAGS_FILEvariable to prepend$(pwd)/, ensuring it's always an absolute path relative to the current working directory.Validation