Skip to content

Conversation

@juecd
Copy link
Contributor

@juecd juecd commented Jul 18, 2025

Running Docker locally requires an absolute path for .tmp/chromium/flags"



TL;DR

Updated run-docker.sh to use an absolute path for Chromium flags, fixing local Docker execution.

Why we made these changes

Local Docker setup for Chromium failed because the flags file was not found without an absolute path.

What changed?

  • images/chromium-headful/run-docker.sh: Modified the FLAGS_FILE variable to prepend $(pwd)/, ensuring it's always an absolute path relative to the current working directory.

Validation

  • Verified local Docker execution works correctly with the absolute path.
  • No testing was performed with unikernels.

@juecd juecd marked this pull request as ready for review July 18, 2025 22:15
@juecd juecd requested review from Sayan- and rgarcia July 18, 2025 22:15
Copy link

@mesa-dot-dev mesa-dot-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What Changed

This PR updates the images/chromium-headful/run-docker.sh script to use an absolute path for the Chromium flags file. The FLAGS_FILE variable is now prepended with $(pwd)/ to ensure it's correctly resolved when running Docker locally, fixing a pathing issue.

Risks / Concerns

This is a low-risk change that improves the local development experience. The author noted that this was not tested with unikernels, which is a minor concern to keep in mind, but the change itself is robust. Great work on this fix!

1 files reviewed | 0 comments | Review on Mesa | Edit Reviewer Settings

@juecd juecd merged commit 5d05b0c into main Jul 20, 2025
3 checks passed
@juecd juecd deleted the cj/run-docker branch July 20, 2025 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants