Change behavior to optionally require Unikernel env variables

[pouwerkerk]

This PR adds an optional require-ukc-vars argument to shared/ensure-common-build-run-vars.sh to only require Unikernel envs when require-ukc-vars is present. This enables ./build-docker.sh to work without specifying UKC_TOKEN and UKC_METRO.

Checklist

• Related issue: [BUG] build-docker.sh seems to require unnecessary Unikernel envs to be set #94
• Changes proposed: Adds an optional require-ukc-vars
• @mentions of the person or team responsible for reviewing proposed changes.

---

Note

Introduce optional require-ukc-vars to conditionally enforce UKC_TOKEN/UKC_METRO, and update Chromium headful/headless build/run scripts to use it.

• Shared:
  • shared/ensure-common-build-run-vars.sh: Add optional require-ukc-vars argument to conditionally require UKC_TOKEN/UKC_METRO; update usage/help text.
• Chromium Images:
  • images/chromium-headful/* and images/chromium-headless/*: Update build-unikernel.sh and run-unikernel.sh to source ensure-common-build-run-vars.sh with require-ukc-vars.

^{Written by Cursor Bugbot for commit 5c19f78. This will update automatically on new commits. Configure here.}

[mesa-dot-dev]

Mesa Description

This PR adds an optional require-ukc-vars argument to shared/ensure-common-build-run-vars.sh to only require Unikernel envs when require-ukc-vars is present. This enables ./build-docker.sh to work without specifying UKC_TOKEN and UKC_METRO.

Checklist

• Related issue: [BUG] build-docker.sh seems to require unnecessary Unikernel envs to be set #94
• Changes proposed: Adds an optional require-ukc-vars
• @mentions of the person or team responsible for reviewing proposed changes.

---

Note

This PR introduces an optional require-ukc-vars flag to make Unikernel environment variable checks conditional, allowing Docker builds to run without requiring Unikernel-specific credentials.

• Shared Utilities:
  • shared/ensure-common-build-run-vars.sh is updated to only enforce UKC_TOKEN and UKC_METRO when the new require-ukc-vars argument is provided.
  • Help text is updated to reflect the new argument.
• Chromium Unikernel Scripts:
  • The build-unikernel.sh and run-unikernel.sh scripts for both chromium-headful and chromium-headless are modified to pass the require-ukc-vars flag, preserving the environment variable requirement for Unikernel-specific operations.

^{Written by Cursor Bugbot for commit 76be1d8. This will update automatically on new commits. Configure here.}

^{Description generated by Mesa. Update settings}

[mesa-dot-dev]

Performed full review of 1d2d45e...76be1d8

Analysis

1. Critical bug on line 33 of shared/ensure-common-build-run-vars.sh using exit 1 instead of return 1 when UKC variables are missing, which will terminate the parent shell session entirely rather than returning an error code.

2. This bug breaks the established error handling pattern from line 10 which correctly uses return 1, creating inconsistent behavior.

3. Impact: When users run unikernel build/run scripts without required UKC variables, their entire terminal session will be killed instead of gracefully returning with an error message.

Tip

Help

Slash Commands:

• /review - Request a full code review
• /review latest - Review only changes since the last review
• /describe - Generate PR description. This will update the PR body or issue comment depending on your configuration
• /help - Get help with Mesa commands and configuration options

^{5 files reviewed | 0 comments | Edit Agent Settings • Read Docs}

[rgarcia]

thanks!