ci: update MCP login to use DNS and key file#46
Merged
masnwilliams merged 1 commit intomainfrom Sep 10, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![mesa-dot-dev[bot]](https://avatars.githubusercontent.com/in/1050077?s=60&v=4){kind=small}
There was a problem hiding this comment.
Performed full review of 4d06008...d12f7c0
Tip
⚡ Quick Actions
This review was generated by Mesa.
Actions:
Slash Commands:
/review- Request a full code review/review latest- Review only changes since the last review/describe- Generate PR description. This will update the PR body or issue comment depending on your configuration/help- Get help with Mesa commands and configuration options
1 files reviewed | 1 comments | Review on Mesa | Edit Reviewer Settings
| - name: Login to MCP Registry | ||
| run: ./mcp-publisher login github-oidc | ||
| run: | | ||
| echo "${{ secrets.MCP_PRIVATE_KEY }}" > key.pem |
There was a problem hiding this comment.
The private key file key.pem should be cleaned up after use to prevent it from remaining on the runner filesystem. Consider adding a cleanup step or using a more secure approach like process substitution: mcp-publisher login dns --domain onkernel.com --private-key-file <(echo "${{ secrets.MCP_PRIVATE_KEY }}")
Agent: 🤖 General
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Updates CI authentication to use a private key and DNS for MCP Registry login, replacing the previous OIDC method.
Why we made these changes
This change aligns our publishing workflow with the new standard authentication mechanism for the MCP Registry. The previous
github-oidcmethod is being replaced to streamline and secure access.What changed?
.github/workflows/publish-mcp.yml:github-oidctodns.MCP_PRIVATE_KEYsecret.Description generated by Mesa. Update settings