ci: use local mcp-publisher for login step#50
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Performed full review of 8bdeccf...e87fd0e
Tip
⚡ Quick Actions
This review was generated by Mesa.
Actions:
Slash Commands:
/review- Request a full code review/review latest- Review only changes since the last review/describe- Generate PR description. This will update the PR body or issue comment depending on your configuration/help- Get help with Mesa commands and configuration options
1 files reviewed | 1 comments | Review on Mesa | Edit Reviewer Settings
| run: | | ||
| echo "${{ secrets.MCP_PRIVATE_KEY }}" > key.pem | ||
| mcp-publisher login dns -domain onkernel.com -private-key-file key.pem | ||
| ./mcp-publisher login dns -domain onkernel.com -private-key-file key.pem |
There was a problem hiding this comment.
There appears to be a potential inconsistency in the binary location. The workflow copies the binary to ../mcp-publisher (line 35) but then tries to make mcp-publisher in the current directory executable (line 37) and uses ./mcp-publisher (this line and line 45). Verify that the binary is actually present in the current directory when this step executes, or update the copy/chmod commands to be consistent with the ./ usage.
Agent: 🤖 General
TL;DR
Updated the
publish-mcp.ymlworkflow to explicitly use the localmcp-publisherbinary for the login step.Why we made these changes
To ensure the CI job uses the specific version of the
mcp-publisherbinary present in the repository, rather than relying on a potentially different or non-existent version in the system's PATH. This improves the reliability and predictability of the publishing process.What changed?
mcp-publishercommand in the "Login to MCP Registry" step is now prefixed with./to execute the local binary in the current directory.Description generated by Mesa. Update settings