Skip to content

ci: use local mcp-publisher for login step#50

Merged
masnwilliams merged 2 commits intomainfrom
mason/ga-release
Sep 10, 2025
Merged

ci: use local mcp-publisher for login step#50
masnwilliams merged 2 commits intomainfrom
mason/ga-release

Conversation

@masnwilliams
Copy link
Copy Markdown
Collaborator

@masnwilliams masnwilliams commented Sep 10, 2025

TL;DR

Updated the publish-mcp.yml workflow to explicitly use the local mcp-publisher binary for the login step.

Why we made these changes

To ensure the CI job uses the specific version of the mcp-publisher binary present in the repository, rather than relying on a potentially different or non-existent version in the system's PATH. This improves the reliability and predictability of the publishing process.

What changed?

  • .github/workflows/publish-mcp.yml: The mcp-publisher command in the "Login to MCP Registry" step is now prefixed with ./ to execute the local binary in the current directory.

Description generated by Mesa. Update settings

@vercel
Copy link
Copy Markdown

vercel Bot commented Sep 10, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
mcp Ready Ready Preview Comment Sep 10, 2025 9:54pm

@masnwilliams masnwilliams merged commit 75f2975 into main Sep 10, 2025
1 of 2 checks passed
@masnwilliams masnwilliams deleted the mason/ga-release branch September 10, 2025 21:52
Copy link
Copy Markdown

@mesa-dot-dev mesa-dot-dev Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performed full review of 8bdeccf...e87fd0e

Tip

⚡ Quick Actions

This review was generated by Mesa.

Actions:

Slash Commands:

  • /review - Request a full code review
  • /review latest - Review only changes since the last review
  • /describe - Generate PR description. This will update the PR body or issue comment depending on your configuration
  • /help - Get help with Mesa commands and configuration options

1 files reviewed | 1 comments | Review on Mesa | Edit Reviewer Settings

run: |
echo "${{ secrets.MCP_PRIVATE_KEY }}" > key.pem
mcp-publisher login dns -domain onkernel.com -private-key-file key.pem
./mcp-publisher login dns -domain onkernel.com -private-key-file key.pem
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Medium Logic

There appears to be a potential inconsistency in the binary location. The workflow copies the binary to ../mcp-publisher (line 35) but then tries to make mcp-publisher in the current directory executable (line 37) and uses ./mcp-publisher (this line and line 45). Verify that the binary is actually present in the current directory when this step executes, or update the copy/chmod commands to be consistent with the ./ usage.
Agent: 🤖 General

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant