-
Notifications
You must be signed in to change notification settings - Fork 2
Simplify browser routing example #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+15
−14
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
58b0ee2
docs: simplify browser routing example
rgarcia 0dfa1fb
docs: annotate response with httpx.Response in browser routing example
rgarcia 407e748
docs: show both raw streaming and buffered curl in routing example
rgarcia 84cb2e3
docs: print buffered body and mention httpx.Response semantics
rgarcia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Browser session leaks if request or curl fails
Low Severity
The previous code wrapped the browser usage in
try/finallyto ensuredelete_by_idwas called even on failure. The new code callsclient.browsers.request()andclient.browsers.curl()without any error handling, so if either raises an exception,delete_by_idis never reached and the remote browser session is leaked on the server. Since this is example code that users will copy, the missing cleanup pattern could lead to orphaned browser sessions in real applications.Reviewed by Cursor Bugbot for commit 84cb2e3. Configure here.