live view telemetry#13
Conversation
|
Firetiger deploy monitoring skipped This PR didn't match the auto-monitor filter configured on your GitHub connection:
Reason: PR title 'live view telemetry' does not indicate changes to kernel API endpoints or Temporal workflows; please provide more details or opt in manually if this affects those areas. To monitor this PR anyway, reply with |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c787d1c. Configure here.
Yoinks in kernel/neko#13 <!-- CURSOR_SUMMARY --> > [!NOTE] > **Low Risk** > Small dependency tag bump and an opt-in telemetry flag in Neko config; no auth or application logic changes in this diff. > > **Overview** > Bumps the **Neko** base image in the chromium-headful Dockerfile from `ghcr.io/kernel/neko/base:3.0.8-v1.5.0` to `3.0.8-v1.6.0`, so built images pick up the newer Neko runtime layer. > > Turns on **Neko telemetry** in `neko.yaml` (`telemetry.enabled: true`) alongside the existing `scaletozero` settings. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit b512186. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->

Note
Medium Risk
Adds a new built-in plugin that asynchronously sends session connect/disconnect events over HTTP, introducing new outbound network behavior and concurrency/queueing paths (though gated by a config flag and tested).
Overview
Adds a new built-in
telemetryplugin that can forward live-view session connect/disconnect events to a configured HTTP endpoint (defaulting tohttp://127.0.0.1:10001/telemetry/events), including a computedduration_mson disconnect.The plugin is opt-in via new flags
telemetry.enabledandtelemetry.endpoint, uses a bounded in-memory queue with a background worker (dropping events when saturated to avoid blocking session goroutines), and includes tests covering disabled behavior, event emission, and non-blocking behavior on endpoint failures.Reviewed by Cursor Bugbot for commit c787d1c. Bugbot is set up for automated code reviews on this repo. Configure here.