Skip to content

live view telemetry#13

Merged
Sayan- merged 4 commits into
masterfrom
sayan/kernel-1301-add-more-events
May 26, 2026
Merged

live view telemetry#13
Sayan- merged 4 commits into
masterfrom
sayan/kernel-1301-add-more-events

Conversation

@Sayan-
Copy link
Copy Markdown
Collaborator

@Sayan- Sayan- commented May 22, 2026

Note

Medium Risk
Adds a new built-in plugin that asynchronously sends session connect/disconnect events over HTTP, introducing new outbound network behavior and concurrency/queueing paths (though gated by a config flag and tested).

Overview
Adds a new built-in telemetry plugin that can forward live-view session connect/disconnect events to a configured HTTP endpoint (defaulting to http://127.0.0.1:10001/telemetry/events), including a computed duration_ms on disconnect.

The plugin is opt-in via new flags telemetry.enabled and telemetry.endpoint, uses a bounded in-memory queue with a background worker (dropping events when saturated to avoid blocking session goroutines), and includes tests covering disabled behavior, event emission, and non-blocking behavior on endpoint failures.

Reviewed by Cursor Bugbot for commit c787d1c. Bugbot is set up for automated code reviews on this repo. Configure here.

@firetiger-agent
Copy link
Copy Markdown

Firetiger deploy monitoring skipped

This PR didn't match the auto-monitor filter configured on your GitHub connection:

Any PR that changes the kernel API. Monitor changes to API endpoints (packages/api/cmd/api/) and Temporal workflows (packages/api/lib/temporal) in the kernel repo

Reason: PR title 'live view telemetry' does not indicate changes to kernel API endpoints or Temporal workflows; please provide more details or opt in manually if this affects those areas.

To monitor this PR anyway, reply with @firetiger monitor this.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit c787d1c. Configure here.

Comment thread server/internal/plugins/telemetry/plugin.go
@Sayan- Sayan- requested review from archandatta and hiroTamada May 22, 2026 22:46
Copy link
Copy Markdown

@hiroTamada hiroTamada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sayan- Sayan- merged commit 148bc06 into master May 26, 2026
4 checks passed
@Sayan- Sayan- deleted the sayan/kernel-1301-add-more-events branch May 26, 2026 18:57
Sayan- added a commit to kernel/kernel-images that referenced this pull request May 27, 2026
Yoinks in kernel/neko#13

<!-- CURSOR_SUMMARY -->
> [!NOTE]
> **Low Risk**
> Small dependency tag bump and an opt-in telemetry flag in Neko config;
no auth or application logic changes in this diff.
> 
> **Overview**
> Bumps the **Neko** base image in the chromium-headful Dockerfile from
`ghcr.io/kernel/neko/base:3.0.8-v1.5.0` to `3.0.8-v1.6.0`, so built
images pick up the newer Neko runtime layer.
> 
> Turns on **Neko telemetry** in `neko.yaml` (`telemetry.enabled: true`)
alongside the existing `scaletozero` settings.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
b512186. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants