feat(ingester): add pending_retry folder#1678
Merged
MarceloRobert merged 2 commits intokernelci:mainfrom Dec 16, 2025
Merged
Conversation
MarceloRobert
added
the
Ingester
AmadeusK525
reviewed
Dec 15, 2025
Comment on lines
+94
to
+96
| archive_dir = os.path.join(spool_dir, "archive") | ||
| failed_dir = os.path.join(spool_dir, "failed") | ||
| pending_retry_dir = os.path.join(spool_dir, "pending_retry") |
Contributor
There was a problem hiding this comment.
We could probably create a little helper struct to pass these around as a single "context object" argument instead of passing all 3 of them
Collaborator
Author
There was a problem hiding this comment.
I just changed in ingest_submissions_parallel since after that they are used separately, I don't think we need to group just the archive and pending_retry dirs
MarceloRobert
force-pushed
the
feat/ingester-pending-retry
branch
from
7953b87 to
f321ab4
Compare
MarceloRobert
changed the title
Fixes issues with file counter since the files were moved directly to archive before their data was processed, since their data was moved to the queue directly. Part of kernelci#1376
MarceloRobert
force-pushed
the
feat/ingester-pending-retry
branch
from
f321ab4 to
d090443
Compare
Also adjusts performance tests docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issues with file counter since the files were moved directly to archive before their data was processed, since their data was moved to the queue directly.
How to test
You can test the move to pending directory by disabling the database connection, and you can test the archival when many files are queued for insertion, only a portion will be inserted at a time.
Part of #1376