feat: introduce hardware listing versioning and update routing#1743
Merged
gustavobtflores merged 2 commits intokernelci:mainfrom Feb 12, 2026
Merged
Conversation
gustavobtflores
changed the title
gustavobtflores
added
the
Frontend
Collaborator
MarceloRobert
left a comment
MarceloRobert
left a comment
There was a problem hiding this comment.
If you add a /v2 route then that page will be accessible even if the env var is set to v1 (because then both /hardware and /hardware/v1 will point to v1, not being able to see v2). Otherwise there's also no point in doing all that mapping if they have just a single search/navigate route value for v2
Comment on lines
+59
to
+64
| {hardwareListingVersion !== 'v2' && ( | ||
| <NewPageBanner | ||
| pageNameId="hardwareListing.bannerTitle" | ||
| pageRoute="/hardware/v1" | ||
| /> | ||
| )} |
Collaborator
There was a problem hiding this comment.
This doesn't really show the banner because if you are at v1 then you can't currently see this page, and if you are at v2 then you disable the banner. I think that for now we should always show this banner. On treeListing there's the same mistake actually...
gustavobtflores
force-pushed
the
feat/hardware-page-featflag
branch
from
30d95ba to
eeb8673
Compare
MarceloRobert
approved these changes
Feb 12, 2026
gustavobtflores
added a commit
to MarceloRobert/dashboard
that referenced
this pull request
Feb 19, 2026
…lci#1743) * feat(hardware): introduce hardware listing versioning and update routing * feat(hardware): add /hardware/v2 route
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a feature flag to switch the Hardware listing between v1 and v2, and refactor route/search handling to be type-safe and avoid hardcoded route strings
Changes
VITE_FEATURE_FLAG_HARDWARE_LISTING_VERSIONand document it in .env.example and README.mdHow to test