Skip to content

Improve filters layout on smaller screens#1837

Merged
MarceloRobert merged 3 commits intokernelci:mainfrom
profusion:feat/improve_filters_layout
Apr 8, 2026
Merged

Improve filters layout on smaller screens#1837
MarceloRobert merged 3 commits intokernelci:mainfrom
profusion:feat/improve_filters_layout

Conversation

@dede999
Copy link
Copy Markdown
Contributor

@dede999 dede999 commented Apr 2, 2026

Description

This PR address the problem about the layout of the filters and it can be tested by inspecting the screen sizes on your browser

Related Issue

Closes #1419

@dede999 dede999 marked this pull request as draft April 2, 2026 20:51
@MarceloRobert MarceloRobert added the Frontend Most or all of the changes for this issue will be in the frontend code. label Apr 6, 2026
@dede999 dede999 force-pushed the feat/improve_filters_layout branch from 3e6e6fe to bea9ead Compare April 6, 2026 20:42
@dede999 dede999 marked this pull request as ready for review April 6, 2026 20:43
Comment thread dashboard/src/hooks/useLogData.ts
Comment thread dashboard/src/components/Filter/Drawer.tsx Outdated
Comment thread dashboard/src/components/Filter/CheckboxSection.tsx Outdated
Comment thread dashboard/src/components/Filter/Drawer.tsx Outdated
Comment thread dashboard/src/components/Filter/Drawer.tsx
Comment thread dashboard/src/components/Filter/Drawer.tsx Outdated
Copy link
Copy Markdown
Contributor

@alanpeixinho alanpeixinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

One small point.
For bigger strings (especially in config section), there is some misalignment between checkboxes and text, and between the boxes itselves.

Image

It is not a problem for navigation, but, if it is simple to address might be worth it.

André Luiz Abdalla Silveira added 2 commits April 7, 2026 14:02
Change w-fit to w-full so the filter container respects the viewport
width instead of expanding to its natural content width.
The linter politely pointed out that `file?.['name']` is more concise
than `file && file['name']`

Closes kernelci#1419
@dede999 dede999 force-pushed the feat/improve_filters_layout branch from f1fc1ad to 62664f7 Compare April 7, 2026 17:03
Copy link
Copy Markdown
Collaborator

@MarceloRobert MarceloRobert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think we can still improve the filter sheet in the future, like hiding sections that have only one option

@MarceloRobert MarceloRobert added this pull request to the merge queue Apr 8, 2026
Merged via the queue into kernelci:main with commit 4590b1a Apr 8, 2026
7 checks passed
@dede999 dede999 deleted the feat/improve_filters_layout branch April 8, 2026 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Frontend Most or all of the changes for this issue will be in the frontend code.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Filter selection screen doesn't follow screen size

4 participants