fix: feedback URL serialization handling in SendFeedback component#1879
Merged
gustavobtflores merged 1 commit intokernelci:mainfrom Apr 28, 2026
Merged
Conversation
gustavobtflores
added
bug
MarceloRobert
approved these changes
Apr 28, 2026
Collaborator
MarceloRobert
left a comment
MarceloRobert
left a comment
There was a problem hiding this comment.
LGTM, I tested and it seems fixed
| setFullLocation(newUrl); | ||
| const fullLocation = useMemo(() => { | ||
| const href = location.href; | ||
| // href is relative (starts with "/"), prepend origin |
Collaborator
There was a problem hiding this comment.
I thought that origin was like "maestro" or "linaro", but I see that it's localhost or staging or production. Maybe worth a comment in the code
alanpeixinho
approved these changes
Apr 28, 2026
Contributor
alanpeixinho
left a comment
alanpeixinho
left a comment
There was a problem hiding this comment.
Everything seems ok
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix feedback URL construction in the side menu so the generated GitHub issue body and email body include the correct current page URL.
Changes
fullLocationfromuseLocation().hrefand prependwindow.location.originwhen neededHow to test (if needed)
Closes #1848